Return-Path: X-Original-To: apmail-shindig-issues-archive@www.apache.org Delivered-To: apmail-shindig-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B82D5105BB for ; Thu, 19 Dec 2013 20:59:08 +0000 (UTC) Received: (qmail 58745 invoked by uid 500); 19 Dec 2013 20:59:07 -0000 Delivered-To: apmail-shindig-issues-archive@shindig.apache.org Received: (qmail 58714 invoked by uid 500); 19 Dec 2013 20:59:07 -0000 Mailing-List: contact issues-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list issues@shindig.apache.org Received: (qmail 58653 invoked by uid 99); 19 Dec 2013 20:59:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Dec 2013 20:59:07 +0000 Date: Thu, 19 Dec 2013 20:59:07 +0000 (UTC) From: "Ryan Baxter (JIRA)" To: issues@shindig.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SHINDIG-1963) Change content-type logic in TokenAuthorizationResponseHandler so application/x-www-form-urlencoded is the default MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SHINDIG-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853308#comment-13853308 ] Ryan Baxter commented on SHINDIG-1963: -------------------------------------- Review: https://reviews.apache.org/r/16401/ > Change content-type logic in TokenAuthorizationResponseHandler so application/x-www-form-urlencoded is the default > ------------------------------------------------------------------------------------------------------------------- > > Key: SHINDIG-1963 > URL: https://issues.apache.org/jira/browse/SHINDIG-1963 > Project: Shindig > Issue Type: Improvement > Affects Versions: 2.5.0, 2.5.0-update1 > Reporter: Ryan Baxter > Assignee: Ryan Baxter > > There is logic in TokenAuthorizationResponseHandler that looks at the content type of the auth response and tried to get the access token and other properties from the response based on the response type. The logic was specific to certain providers, ie Google uses one content type, Facebook uses another. I ran into a problem today where the GitHub provider used a different content type but essentially was the same as Facebook. To simplify things I think we should default to handling the response as application/x-www-form-urlencoded unless they specify a different content type that we know how to handle (right now that is application/json). -- This message was sent by Atlassian JIRA (v6.1.4#6159)