Return-Path: X-Original-To: apmail-shindig-issues-archive@www.apache.org Delivered-To: apmail-shindig-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A7AC9271 for ; Fri, 4 May 2012 14:49:12 +0000 (UTC) Received: (qmail 14430 invoked by uid 500); 4 May 2012 14:49:11 -0000 Delivered-To: apmail-shindig-issues-archive@shindig.apache.org Received: (qmail 14399 invoked by uid 500); 4 May 2012 14:49:11 -0000 Mailing-List: contact issues-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list issues@shindig.apache.org Received: (qmail 14360 invoked by uid 99); 4 May 2012 14:49:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 14:49:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 14:49:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 27FAD4301FF for ; Fri, 4 May 2012 14:48:50 +0000 (UTC) Date: Fri, 4 May 2012 14:48:50 +0000 (UTC) From: "jiraposter@reviews.apache.org (JIRA)" To: issues@shindig.apache.org Message-ID: <311247958.27194.1336142930165.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1317873879.22060.1336056895386.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (SHINDIG-1766) Inject default style into gadgets to allow inner content to scroll. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268409#comment-13268409 ] jiraposter@reviews.apache.org commented on SHINDIG-1766: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4973/#review7560 ----------------------------------------------------------- Ship it! Committed r1333997 - Dan On 2012-05-03 14:54:20, Dan Dumont wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4973/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-05-03 14:54:20) bq. bq. bq. Review request for shindig. bq. bq. bq. Summary bq. ------- bq. bq. I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists. bq. bq. bq. This addresses bug SHINDIG-1766. bq. https://issues.apache.org/jira/browse/SHINDIG-1766 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049 bq. bq. Diff: https://reviews.apache.org/r/4973/diff bq. bq. bq. Testing bq. ------- bq. bq. All tests pass. bq. bq. bq. Thanks, bq. bq. Dan bq. bq. > Inject default style into gadgets to allow inner content to scroll. > ------------------------------------------------------------------- > > Key: SHINDIG-1766 > URL: https://issues.apache.org/jira/browse/SHINDIG-1766 > Project: Shindig > Issue Type: Improvement > Reporter: Dan Dumont > Assignee: Dan Dumont > Attachments: shindig.patch > > > There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira