shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1707) Path To JS Servlet Not Passed As Param For Gadgets Of Type URL
Date Thu, 12 Apr 2012 13:35:20 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252419#comment-13252419
] 

jiraposter@reviews.apache.org commented on SHINDIG-1707:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4710/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Fix shindig to implement the stated spec, that the libs param should be a url to download
feature impl, not just a list of features.

Additional conversation on the spec list here: https://groups.google.com/d/topic/opensocial-and-gadgets-spec/7lGzhk67nY8/discussion


This addresses bug SHINDIG-1707.
    https://issues.apache.org/jira/browse/SHINDIG-1707


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/url-gadget-with-features/url.html
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/url-gadget-with-features/url.xml
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
1311965 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java
1311965 

Diff: https://reviews.apache.org/r/4710/diff


Testing
-------

Updated unit tests to expect the new url.
All tests pass.

Added a sample url gadget and html page to show the feature working.


Thanks,

Dan


                
> Path To JS Servlet Not Passed As Param For Gadgets Of Type URL
> --------------------------------------------------------------
>
>                 Key: SHINDIG-1707
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1707
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Ryan Baxter
>
> When Shindig renders views of gadgets of type URL, certain parameters are passed that
should allow the application at that URL to request the javascript for the features the gadget
uses.  (See http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#rfc.section.3.4)
 Today you get the host of the server and the features the gadget uses, but you do not get
the path to the JS servlet.  Since the servlet can be configured in the web.xml it is possible
that the path is different depending on the instance.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message