shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1725) osapi.container.util.warn causes errors when used in Internet Explorer
Date Thu, 08 Mar 2012 20:03:58 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225450#comment-13225450
] 

jiraposter@reviews.apache.org commented on SHINDIG-1725:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4247/#review5746
-----------------------------------------------------------

Ship it!


+1

- Henry


On 2012-03-08 17:30:51, Stanton Sievers wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4247/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-08 17:30:51)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Remove osapi.container.util.warn because it only serves to cause issues in IE.  Replace
it with gadgets.warn instead.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1725.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1725
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html
1298060 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
1298060 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
1298060 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1298060 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
1298060 
bq.  
bq.  Diff: https://reviews.apache.org/r/4247/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Modified the sample common container to allow me to hit the code paths I'm testing. 
These changes are part of the patch and I can drop them if we really don't want them going
back to Shindig.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Stanton
bq.  
bq.


                
> osapi.container.util.warn causes errors when used in Internet Explorer
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1725
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1725
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.5.0
>         Environment: Internet Explorer 8
>            Reporter: Stanton Sievers
>            Assignee: Stanton Sievers
>             Fix For: 2.5.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> osapi.container.util.warn uses "console" to do logging.  IE complains when "console"
is undefined even though the code is checking truthiness. 
> osapi.container.util.warn is only used by osapi.container.GadgetSite.prototype.navigateTo
and the proposed fix would be to remove osapi.container.util.warn completely and replace it
with gadgets.warn, which handles the console object appropriately across browsers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message