shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1695) new core-gadget feature "proxied-form-post" gadgets.proxiedMultipartFormPost
Date Tue, 07 Feb 2012 21:15:00 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202798#comment-13202798
] 

jiraposter@reviews.apache.org commented on SHINDIG-1695:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/
-----------------------------------------------------------

(Updated 2012-02-07 21:13:45.353118)


Review request for Ryan Baxter and Stanton Sievers.


Changes
-------

Caught some errors while testing.


Summary
-------

With the desire to deprecate the makeRequest API, we still need a method to post files through
the proxy. This new feature should not be bundled in with core, it should need to be explicitly
requested. 

It should allow modern browsers such as FF and Chrome to monitor form post progress. It should
still be functional (do the post) for less capable browsers like IE, even though post progress
may not be available.


This addresses bug SHINDIG-1695.
    https://issues.apache.org/jira/browse/SHINDIG-1695


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
1241308 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java
1241308 

Diff: https://reviews.apache.org/r/3768/diff


Testing
-------


Thanks,

Dan


                
> new core-gadget feature "proxied-form-post" gadgets.proxiedMultipartFormPost
> ----------------------------------------------------------------------------
>
>                 Key: SHINDIG-1695
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1695
>             Project: Shindig
>          Issue Type: New Feature
>            Reporter: Dan Dumont
>            Assignee: Dan Dumont
>
> With the desire to deprecate the makeRequest API, we still need a method to post files
through the proxy.  This new feature should not be bundled in with core, it should need to
be explicitly requested.
> It should allow modern browsers such as FF and Chrome to monitor form post progress.
 It should still be functional (do the post) for less capable browsers like IE, even though
post progress may not be available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message