shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1704) rpc does not support communicating with gadget created in an existing iframe
Date Mon, 27 Feb 2012 08:57:49 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217117#comment-13217117
] 

jiraposter@reviews.apache.org commented on SHINDIG-1704:
--------------------------------------------------------



bq.  On 2012-02-15 14:43:55, Dan Dumont wrote:
bq.  > Could you please provide a bit more information on the use case that you are trying
and what's going on?  I want to make sure I understand this before I review.
bq.  > 
bq.  > Also, there's a bunch of whitespace that needs to be cleaned up.  Please remove
all trailing line whitespace    =~/[ \t]+$//; (if you'll forgive my perl)
bq.  > Also, please use tab = 2 spaces + convert tabs to spaces.

Hi Dan, the story is:
When you try to render a gadget to a certain dom node like this: 
var cc = new osapi.container.Container({});
var site = cc.newGadgetSite(siteEle/*an existing dom node*/);
cc.navigateGadget(site,....);

Gadget rendering will fail if siteEle is a dom node is in side an iframe in top paranet window.
The cause is rpc code is assuming the input dom node is just in the top parent window.


- Yao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review5123
-----------------------------------------------------------


On 2012-02-15 04:09:39, Yao Zhang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3908/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-15 04:09:39)
bq.  
bq.  
bq.  Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When you try to render a gadget to a dom node inside an existing iframe, rpc does not
work as the code is using document.getElementById to get the domnode
bq.  
bq.  
bq.  This addresses bug SHINDIG-1704.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1704
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
1238149 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1238149 
bq.  
bq.  Diff: https://reviews.apache.org/r/3908/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Yao
bq.  
bq.


                
> rpc does not support communicating with gadget created in an existing iframe
> ----------------------------------------------------------------------------
>
>                 Key: SHINDIG-1704
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1704
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.2
>            Reporter: Yao Zhang
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc does not
work as the code is using document.getElementById to get the domnode. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message