shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1686) The gadgets.views.init does not check for the view name if it contains secondary view
Date Sat, 28 Jan 2012 19:50:11 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195614#comment-13195614
] 

jiraposter@reviews.apache.org commented on SHINDIG-1686:
--------------------------------------------------------



bq.  On 2012-01-28 14:51:06, Stanton Sievers wrote:
bq.  > Quick question to help clarify.  This patch assumes that the conf cannot have views
that have subviews.  In the code, you query supportedViews for the viewMajor, for instance,
"canvas".  Is this saying that it's invalid for me in my container.js to have view configuration
for "canvas.help"?

Yes, thats what I understand from the spec for gadgets.views.getSupportedViews in the core
gadget http://opensocial-resources.googlecode.com/svn/spec/2.0.1/Core-Gadget.xml#gadgets.views.getSupportedViews:
"This function only returns the primary views and does not return any secondary views. Example:
if the markup indicates a set of views named Canvas.About, Profile.About, Home.About, Canvas.Help
the returned views will only be Canvas, Profile, Home."

So looks like the list of supported views will only return the primary list of view names
without the secondary ones. I think this is bc you can have a lot of secondary views that
are variants of the primary views. It would be really hard to limit what possible secondary
views in the conf file.


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3666/#review4671
-----------------------------------------------------------


On 2012-01-27 22:11:34, Henry Saputra wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3666/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-27 22:11:34)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  See jira: SHINDIG-1686 (https://issues.apache.org/jira/browse/SHINDIG-1686) for detail
about the issue.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1686.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1686
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/features/src/main/javascript/features/views/views.js 1236784 
bq.    trunk/features/src/test/javascript/features/views/views-init-test.js 1236784 
bq.  
bq.  Diff: https://reviews.apache.org/r/3666/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Modify the JS unit test to test the subview. Run simple apps in common container with
different views and subviews.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Henry
bq.  
bq.


                
> The gadgets.views.init does not check for the view name if it contains secondary view

> --------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1686
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1686
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 3.0.0
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>              Labels: opensocial, shindig, view
>
> The gadgets.views.init function initializes the current view by checking the "view" URL
parameter. However the code does not consider the possibility of the view name to have secondary
name separated by "." char.
> The spec: http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml says
that gadgets.views.View function only returns the primary view names, however calling the
getCurrentView should return gadgets.views.View object that has gadgets.views.View.name_ set
to the full view as defined in the "view" url parameter if the primary part of the view available
in the list of gadgets.views.getSupportedViews(). 
> Otherwise  try to return "default" view as before.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message