shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1666) Metadata request may not return an array of gadget URLs when there is an error it may just return an error code and message need to account for that in EE code
Date Tue, 06 Dec 2011 14:35:41 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163624#comment-13163624
] 

jiraposter@reviews.apache.org commented on SHINDIG-1666:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/#review3661
-----------------------------------------------------------

Ship it!


LGTM

- Dan


On 2011-12-06 14:20:46, Ryan Baxter wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3005/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-06 14:20:46)
bq.  
bq.  
bq.  Review request for shindig and Stanton Sievers.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When preloading a gadget the response usually is an array of gadget URLs with data about
the gadget. However sometimes the response may actually just be an error code and message.
We need to account for that case in the handler in the EE code.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1666.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1666
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
1207574 
bq.  
bq.  Diff: https://reviews.apache.org/r/3005/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit tests and common container
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ryan
bq.  
bq.


                
> Metadata request may not return an array of gadget URLs when there is an error it may
just return an error code and message need to account for that in EE code
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1666
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1666
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: fix-1666.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> When preloading a gadget the response usually is an array of gadget URLs with data about
the gadget.  However sometimes the response may actually just be an error code and message.
 We need to account for that case in the handler in the EE code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message