shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1653) Add callback function to print timing information for gadget preloading.
Date Tue, 01 Nov 2011 23:49:33 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141775#comment-13141775
] 

jiraposter@reviews.apache.org commented on SHINDIG-1653:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/
-----------------------------------------------------------

(Updated 2011-11-01 23:49:25.743392)


Review request for shindig.


Summary
-------

We already have a callback function for navigating gadgets in the common container which can
be used to print timing information. Problem is if you preload the gadget before navigating
the timing information during navigation is 0. It would be helpful to print timing information
for preloading as well.


This addresses bug SHINDIG-1653.
    https://issues.apache.org/jira/browse/SHINDIG-1653


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
1190425 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/util_test.js
1190425 

Diff: https://reviews.apache.org/r/2616/diff


Testing (updated)
-------

Modified sample container to log this information and updated unit tests.


Thanks,

Ryan


                
> Add callback function to print timing information for gadget preloading.
> ------------------------------------------------------------------------
>
>                 Key: SHINDIG-1653
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1653
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> We already have a callback function for navigating gadgets in the common container which
can be used to print timing information.  Problem is if you preload the gadget before navigating
the timing information during navigation is 0.  It would be helpful to print timing information
for preloading as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message