shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1661) need to load default features before extended feature
Date Wed, 16 Nov 2011 14:34:52 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151233#comment-13151233
] 

jiraposter@reviews.apache.org commented on SHINDIG-1661:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2851/
-----------------------------------------------------------

Review request for shindig and Henry Saputra.


Summary
-------

Right now extended javascript features is always loaded first than default javascript features.
This is okay for normal case. However if we'd like an extended feature to overwrite an default
feature, this would become a problem.
The simple fix would address this issue.


This addresses bug SHINDIG-1661.
    https://issues.apache.org/jira/browse/SHINDIG-1661


Diffs
-----

  /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1202451


Diff: https://reviews.apache.org/r/2851/diff


Testing
-------

passed junit test.


Thanks,

li


                
> need to load default features before extended feature
> -----------------------------------------------------
>
>                 Key: SHINDIG-1661
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1661
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>         Environment: all
>            Reporter: li xu
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: patch_load_feature
>
>
> Right now extended javascript features is always loaded first than default javascript
features.
> This is okay for normal case. However if we'd like an extended feature to overwrite an
default feature, this would become a problem. 
> The simple fix would address this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message