shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1601) Enhance Gadget Administration
Date Sat, 01 Oct 2011 04:14:46 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118661#comment-13118661
] 

jiraposter@reviews.apache.org commented on SHINDIG-1601:
--------------------------------------------------------



bq.  On 2011-09-30 22:37:19, Henry Saputra wrote:
bq.  > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java,
line 54
bq.  > <https://reviews.apache.org/r/1666/diff/7/?file=47001#file47001line54>
bq.  >
bq.  >     Why do we inject BasicGadgetAdminStore instead of GadgetAdminStore?
bq.  >     
bq.  >     Are we expecting Shindig implementors to override the GadgetAdminModule? I believe
the config/gadget-admin.json file contain initial whitelisting list of gadgets? 
bq.  >     
bq.  >     It would be better if we could find a way to provide plugin or injectable hook
to different data source to load this initial whitelist gadgets def.
bq.  
bq.  Ryan Baxter wrote:
bq.      I was thinking the people who want to use something else than the gadget-admin.json
file they would override the DefaultGuiceModule.  They could choose to override the GadgetAdminStore
if they want...

I would think its better to have the admin store injection as provider and same as the initial
whitelist gadgets. We should try to make code that does not need to be modified to be flexible
enough to allow extension in the right place rather than override the whole DefaultGuiceModule.


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1666/#review2240
-----------------------------------------------------------


On 2011-09-30 19:21:13, Ryan Baxter wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1666/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-30 19:21:13)
bq.  
bq.  
bq.  Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, Dan Dumont, and Stanton
Sievers.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  We want to add some administration features to Shindig.  This patch adds/changes 3 things
in Shindig.
bq.  
bq.  1.  Remove the existing blacklist functionality in Shindig which currently is enabled
by pointing Shindig to a text file with a list of gadgets to blacklist.  The new functionality
uses a whitelist instead of a blacklist and is indexed on a per container basis.  Meaning
an admin could whitelist some gadgets in one container but not another.  This functionality
is enabled through a Guice module allowing implementors to use something else besides a text
file.
bq.  
bq.  2.  Add the ability for administrators to specify which features are allowed and denied
for a specific gadget in a specific container.  This information is checked in two places,
when the metadata request is made and when the gadget is rendered.
bq.  
bq.  3.  Add the ability for containers to secure RPC requests made by gadgets.  The RPC code
now has the ability to arbitrate all RPC calls made.  Containers can specify their own arbitrator.
 The common container has its own default arbitrator available.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1601.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1601
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/config/gadget-admin.json PRE-CREATION

bq.    http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1177430

bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/logging/i18n/MessageKeys.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/pom.xml 1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicGadgetBlacklist.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetBlacklist.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStore.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/FeatureAdminData.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminData.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminStore.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ServerAdminData.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/CoreUtilConfigContributor.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/BasicGadgetBlacklistTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/FeatureAdminDataTest.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/GadgetAdminDataTest.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ServerAdminDataTest.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeProcessor.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java
1177430 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java
1177430 
bq.  
bq.  Diff: https://reviews.apache.org/r/1666/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Created/updated unit tests.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ryan
bq.  
bq.


                
> Enhance Gadget Administration
> -----------------------------
>
>                 Key: SHINDIG-1601
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1601
>             Project: Shindig
>          Issue Type: New Feature
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>         Attachments: issue-1601.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> We want to add some administration features to Shindig.  This patch adds/changes 3 things
in Shindig.
> 1.  Remove the existing blacklist functionality in Shindig which currently is enabled
by pointing Shindig to a text file with a list of gadgets to blacklist.  The new functionality
uses a whitelist instead of a blacklist and is indexed on a per container basis.  Meaning
an admin could whitelist some gadgets in one container but not another.  This functionality
is enabled through a Guice module allowing implementors to use something else besides a text
file.
> 2.  Add the ability for administrators to specify which features are allowed and denied
for a specific gadget in a specific container.  This information is checked in two places,
when the metadata request is made and when the gadget is rendered.
> 3.  Add the ability for containers to secure RPC requests made by gadgets.  The RPC code
now has the ability to arbitrate all RPC calls made.  Containers can specify their own arbitrator.
 The common container has its own default arbitrator available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message