shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1652) Selection service deesn't work correctly in IE8
Date Thu, 27 Oct 2011 19:24:33 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137415#comment-13137415
] 

jiraposter@reviews.apache.org commented on SHINDIG-1652:
--------------------------------------------------------



bq.  On 2011-10-27 19:22:25, Dan Dumont wrote:
bq.  > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js,
line 81
bq.  > <https://reviews.apache.org/r/2576/diff/2/?file=53802#file53802line81>
bq.  >
bq.  >     The way I like to write this is:
bq.  >     for (var i = 0, savedListener; savedListener=listeners[i]; i++) {
bq.  >       // no need to check length.
bq.  >       if(savedListener===listener) {
bq.  >         listeners.splice(i, 1);
bq.  >         break;
bq.  >       }
bq.  >     }

Only do that, though, if you know your array will not have falsey values (null, undefined,
"", or 0, etc)


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2576/#review2883
-----------------------------------------------------------


On 2011-10-27 15:45:02, Jason Chiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2576/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-27 15:45:02)
bq.  
bq.  
bq.  Review request for shindig, Ryan Baxter and Dan Dumont.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  IE8 doesn't support both "forEach" and "indexOf" Javascript methods, replace these methods
with for loop.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1652.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1652
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1189339 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
1189339 
bq.  
bq.  Diff: https://reviews.apache.org/r/2576/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Test it with the sample container in IE8
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jason
bq.  
bq.


                
> Selection service deesn't work correctly in IE8
> -----------------------------------------------
>
>                 Key: SHINDIG-1652
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1652
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 3.0.0
>         Environment: IE8
>            Reporter: Jason Chiang
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> IE8 doesn't support Javascript forEach method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message