shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1592) EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080
Date Wed, 24 Aug 2011 20:14:31 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090447#comment-13090447
] 

jiraposter@reviews.apache.org commented on SHINDIG-1592:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
-----------------------------------------------------------

(Updated 2011-08-24 20:14:29.491196)


Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.


Changes
-------

Thanks for catching this, Ryan.
is all the procedure documented somewhere? seems like I missed a few...
 


Summary
-------

This fix enables EE sample page to work out of box even if it's deployed with a context root
other than root or port other than 8080

we added two tokens at sample db: canonicaldb.json
%contextroot%
%origin%
it's resolved by JsonDBOpensocialService.java based on injected hostProvider
This is a generic change... any other opensocial object could use the same token in sample
json db.

Opensocial sample context is updated to include an additional attribute since photogadget.xml
need to refer to AlbumViewer.xml
            "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
fixed related junit tests.

Thanks to Ryan's help on this! 


This addresses bug shindig-1592.
    https://issues.apache.org/jira/browse/shindig-1592


Diffs
-----

  /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372 
  /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372 
  /trunk/content/sampledata/canonicaldb.json 1160372 
  /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1160372 
  /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml
1160372 
  /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
1160372 
  /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json
1160372 
  /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json
1160372 
  /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml
1160372 

Diff: https://reviews.apache.org/r/1616/diff


Testing
-------

Passed JUnit tests.
Tested with /embeddedexperiences/index.html


Thanks,

li



> EE sample gadget doesn't work out of box if deployed with context other than root or
deployed on port other than 8080
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1592
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1592
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: li xu
>            Priority: Minor
>              Labels: shindig
>             Fix For: 3.0.0
>
>         Attachments: patch0824
>
>
> This fix enables EE sample page to work out of box even if it's deployed with a context
root other than root or port other than 8080
> we added two tokens at sample db: canonicaldb.json
> %contextroot%
> %origin%
> it's resolved by JsonDBOpensocialService.java based on injected hostProvider
> This is a generic change... any other opensocial object could use the same token in sample
json db.
> Opensocial sample context is updated to include an additional attribute since photogadget.xml
need to refer to AlbumViewer.xml
>             "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
> fixed related junit tests.
> Thanks to Ryan's help on this!

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message