shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1594) Cross domain RPC calls failing
Date Wed, 24 Aug 2011 17:56:31 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090372#comment-13090372
] 

jiraposter@reviews.apache.org commented on SHINDIG-1594:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1635/
-----------------------------------------------------------

(Updated 2011-08-24 17:56:11.813508)


Review request for shindig.


Changes
-------

Not sure how I managed to not upload the diff.   Here it is.


Summary
-------

I ran into an issue loading the container across domains with the recent change.   This should
fix it.


This addresses bug SHINDIG-1594.
    https://issues.apache.org/jira/browse/SHINDIG-1594


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1160787 

Diff: https://reviews.apache.org/r/1635/diff


Testing
-------


Thanks,

Dan



> Cross domain RPC calls failing
> ------------------------------
>
>                 Key: SHINDIG-1594
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1594
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>
> Because of some recent changes in callSameDomain, cross domain RPC calls are failing.
 The RPC code calls callSameDomain even for cross domain calls expecting it to return false,
however with some recent changes we can get into a state where the second time we call callSameDomain
for the same gadget it will not fail and we try to call functions across different domains,
which is not allowed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message