shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1578) Improve gadgets.util.registerOnLoadHandler to be reliable for slow or lazy loading gadgets
Date Thu, 18 Aug 2011 01:43:28 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086733#comment-13086733
] 

jiraposter@reviews.apache.org commented on SHINDIG-1578:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1525/#review1518
-----------------------------------------------------------


I like this change, makes sense with your explanation.  What do you think Henry?

- Ryan


On 2011-08-17 15:18:59, Dan Dumont wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1525/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-17 15:18:59)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  If gadgets.util.registerOnLoadHandler was called after the runOnLoad counterpart was
called, the callback would sit in the array... forever alone.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1578.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1578
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js
1157211 
bq.  
bq.  Diff: https://reviews.apache.org/r/1525/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Dan
bq.  
bq.



> Improve gadgets.util.registerOnLoadHandler to be reliable for slow or lazy loading gadgets
> ------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1578
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1578
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Javascript 
>            Reporter: Dan Dumont
>            Priority: Minor
>
> The sequence of events is:
> 1) Gadget starts loading and registers some onload.
> 2) Gadget fires an async operation that takes an unknown amount of time
> 3) Open Social api is ready and runOnLoadHandlers is called.
> 4) Gadget's async operation is done.  To be safe it uses registerOnLoadHandler to make
sure everything is all set (in case the async operation beat the runOnLoadHandlers call)
> At this point, the call to registerOnLoadHandler would never result in the callback being
executed.
> This should be changed to make it so once runOnLoadHandlers is called, registerOnLoadHandler
executes the callback immediately.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message