shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHINDIG-1607) Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration
Date Tue, 30 Aug 2011 14:11:40 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093750#comment-13093750
] 

jiraposter@reviews.apache.org commented on SHINDIG-1607:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1682/
-----------------------------------------------------------

Review request for Ryan Baxter and Stanton Sievers.


Summary
-------

It looks like the current impl of declarative actions pick the first gadget site where the
URL matches and fires the action in that.  The actions spec lets you specify a target view,
so we should make sure to check if the site has that view rendered.   It may also be rendered
more than once, so we should fire the action in all of them.


This addresses bug SHINDIG-1607.
    https://issues.apache.org/jira/browse/SHINDIG-1607


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1161182 

Diff: https://reviews.apache.org/r/1682/diff


Testing
-------


Thanks,

Dan



> Declared actions get fired in the first instance of the gadget, ignoring any specified
view target in the declaration
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1607
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1607
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>            Reporter: Dan Dumont
>
> It looks like the current impl of declarative actions pick the first gadget site where
the URL matches and fires the action in that.  The actions spec lets you specify a target
view, so we should make sure to check if the site has that view rendered.   It may also be
rendered more than once, so we should fire the action in all of them.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message