shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mat Mannion (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHINDIG-1516) Passing "rawxml" param w/o "url" param throws exception when processing spec
Date Sat, 12 Mar 2011 00:10:59 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005911#comment-13005911
] 

Mat Mannion commented on SHINDIG-1516:
--------------------------------------

Hi Dennis,

Can you re-base your patch to be relative to the root, please, rather than the directory that
Processor.java is in? At the moment this is stopping the code review working. It looks okay
to me, though there are a couple of indenting issues I think where it doesn't match the shindig
style (tabs instead of 4 spaces)

> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
>                 Key: SHINDIG-1516
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1516
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 2.0.3, 3.0.0
>            Reporter: Dennis Ju
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects
a well-formed url parameter even though it is unneeded. A missing url parameter will throw
an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message