shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Feng Zhang (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SHINDIG-1460) Bug fix and improvement for common container: make gadgets can be rendered successfully with the new common container
Date Thu, 04 Nov 2010 03:57:42 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928094#action_12928094
] 

Kai Feng Zhang edited comment on SHINDIG-1460 at 11/3/10 11:56 PM:
-------------------------------------------------------------------

I upload the patch here: http://codereview.appspot.com/2889041/   , please get a review..thanks.

      was (Author: zhangkf):
    I upload the patch here: http://codereview.appspot.com/2889041/, please get a review..thanks.
  
> Bug fix and improvement for common container: make gadgets can be rendered successfully
with the new common container
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1460
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1460
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Javascript 
>    Affects Versions: 3.0.0
>            Reporter: Kai Feng Zhang
>             Fix For: 3.0.0
>
>         Attachments: common_container_1101.patch, common_container_1104.patch
>
>
> Working sample page on the new container, there are some issues we have to fix:
> 1. client side called "osapi.gadgets.metadata.get", but server side can't find that method,
the key in the
> mapping of the rpc handler is "gadgets.metadata".
> 2. when creating the new metadatarequest in "util.js" in the new container, it used 'container':
> window.__CONTAINER, but window.__CONTAINER is undefined, we need provide one in the sample
page or define it in the
> constants.js. Currently the patch provide one in the sample page.
> 3. after the above issues are  fixed, the returned iframeurl in metadata is something
like this
> "//http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-pubsub-2-publisher.xml&
> amp;container=default&view=%25view%25&lang=%25lang%25&country=%25country%25&debug=%25debug%25&nocach
> e=%25nocache%25"
> The url began with two slashes. we have to remove them.
> One approach is changing it when generating the iframeurl on the server side, in the
file of
> "DefaultIframeUriManager", another approach is changing it on the client side when setting
it to the iframe
> src, in the file of "gadgets_holder.js".
> Currently the patch is based on the second approach.
> ----
> A new patch including following fixes and a sample page:
> 1. make gadgets.metadata.get can return the gadget's metadata
> 2. delete the slashes before the iframeurl
> 3. add pubsub-2 support in the common container
> 4. fix the security token issue if the gadget requires
> "security-token" feature.
> ----
> Latest patch:
> 1. change osapi.gadgets.metadata.get to osapi.gadgets.metadata
> in service.js
> 2. remove the leading "//" of the url to server side

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message