shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nenad Nikolic (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHINDIG-803) hasFeature does not work
Date Wed, 23 Dec 2009 01:39:30 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793877#action_12793877
] 

Nenad Nikolic commented on SHINDIG-803:
---------------------------------------

Before reporting the same problem, I did a search and - sure enough, someone noticed this
a while ago.

Anyway, incidentally I've developed together with my colleague a similar feature test gadget.
It actually goes around this bug in Shindig, checks for available features anyway and correctly
finds what features are available without having to use hasFeature. This gadget is appropriately
called FIG (Feature Inspection Gadget). :-)

Here's it is:
http://shonzilla.com/gadgets/fig.xml

> hasFeature does not work
> ------------------------
>
>                 Key: SHINDIG-803
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-803
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java, Javascript 
>    Affects Versions: 1.0
>            Reporter: Henning Schmiedehausen
>         Attachments: SHINDIG-803.patch
>
>
> Digging through the code; I have a test gadget that displays the compliance level of
a javascript container. It is available at http://henning.schmiedehausen.org/gadgets/check.xml.
This loads all opensocial features as optional and then displays the results of hasFeature(),
which should only be true if a feature actually exists. 
> Consider me surprised, when this gadget found out that most popular containers already
support opensocial-1.0. :-)
> The current shindig code builds an array of features from the gadget in RenderingContentRewriter.java:354.
For all features referenced by the gadget, this will contain an entry with the configuration.
Even for the ones that are optional.
> in core.io/utils.js, the hasFeature() method only tests the presence of a key in this
array. Which is always present if a feature is referenced by the gadget spec. No matter whether
it exists or not. It will always report the feature existing. As the Optional/hasFeature combo
is the only way to find out whether a given feature requested by a gadget is actually present,
I consider this a bug. :-) 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message