shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Voorhees (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHINDIG-1223) On Windows the Java feature loading code throws IllegalArgumentException or URISyntaxException when searching directories
Date Mon, 07 Dec 2009 18:23:18 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787027#action_12787027
] 

Stephen Voorhees commented on SHINDIG-1223:
-------------------------------------------

I tried Bruce's suggestion of backing out 883605 and applying the fix-1223-alternate2.patch
and the build errors on Windows went away.  Any chance of applying this in the near future?

Thanks!



> On Windows the Java feature loading code throws IllegalArgumentException or URISyntaxException
when searching directories
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1223
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1223
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>         Environment: Windows XP
>            Reporter: Bruce Godden
>         Attachments: fix-1223-alternate2.patch, fix-1223-bug.patch, TEST-org.apache.shindig.gadgets.features.FeatureRegistryTest.xml,
TEST-org.apache.shindig.gadgets.features.FeatureRegistryTest.xml
>
>
> On Windows the build fails reporting errors in three tests:
>   registerFromFileFeatureXmlFileScheme(org.apache.shindig.gadgets.features.FeatureRegistryTest)
>   registerFromFileFeatureXmlNoScheme(org.apache.shindig.gadgets.features.FeatureRegistryTest)
>   registerFromFileInNestedDirectoryFeatureXmlFile(org.apache.shindig.gadgets.features.FeatureRegistryTest)
> I have tracked these down to the way that Shindig handles file paths. The tests create
some test files or directories then pass the actual paths of these into UriBuilder(). This
results in malformed URIs being reported as the path is expected to start with a slash. Also,
the way that test XML feature files are constructed using replaceAll() means that the Windows
backslash path separators are discard from the URIs inserted into the test files.
> Sadly this problem is not only in the test code. The FeatureRegistry class does the same
sort of thing when searching a directory tree for feature files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message