shindig-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruce Godden (JIRA)" <>
Subject [jira] Commented: (SHINDIG-1223) On Windows the Java feature loading code throws IllegalArgumentException or URISyntaxException when searching directories
Date Tue, 01 Dec 2009 14:21:21 GMT


Bruce Godden commented on SHINDIG-1223:

The new patch fix-1223-alternate2.patch doesn't seem to be based on the current source. I
think revision 883605 has gotten in the way.

It looks like a couple of attempts have been made to fix this problem: revisions 880925 and
883605. Neither seem to have been entirely successful though.

After revision 880925 there was only one failure. (See comment dated 17/Nov/09 above.)

It seems that revision 883605 has undone some of the changes that 880925 made and tried to
fix the problems a different way. This has resulted in the three original errors coming back.

When I tried syncing back to revision 880925 and applying patch fix-1223-alternate2.patch
then the remaining failure did go away.

I suggest backing out revision 883605 then applying patch fix-1223-alternate2.patch.

> On Windows the Java feature loading code throws IllegalArgumentException or URISyntaxException
when searching directories
> -------------------------------------------------------------------------------------------------------------------------
>                 Key: SHINDIG-1223
>                 URL:
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>         Environment: Windows XP
>            Reporter: Bruce Godden
>         Attachments: fix-1223-alternate2.patch, fix-1223-bug.patch, TEST-org.apache.shindig.gadgets.features.FeatureRegistryTest.xml,
> On Windows the build fails reporting errors in three tests:
>   registerFromFileFeatureXmlFileScheme(org.apache.shindig.gadgets.features.FeatureRegistryTest)
>   registerFromFileFeatureXmlNoScheme(org.apache.shindig.gadgets.features.FeatureRegistryTest)
>   registerFromFileInNestedDirectoryFeatureXmlFile(org.apache.shindig.gadgets.features.FeatureRegistryTest)
> I have tracked these down to the way that Shindig handles file paths. The tests create
some test files or directories then pass the actual paths of these into UriBuilder(). This
results in malformed URIs being reported as the path is expected to start with a slash. Also,
the way that test XML feature files are constructed using replaceAll() means that the Windows
backslash path separators are discard from the URIs inserted into the test files.
> Sadly this problem is not only in the test code. The FeatureRegistry class does the same
sort of thing when searching a directory tree for feature files.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message