Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 506A8E646 for ; Thu, 14 Feb 2013 23:45:08 +0000 (UTC) Received: (qmail 48059 invoked by uid 500); 14 Feb 2013 23:45:08 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 48019 invoked by uid 500); 14 Feb 2013 23:45:08 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 48010 invoked by uid 99); 14 Feb 2013 23:45:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2013 23:45:07 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of m.ben.franklin@gmail.com designates 209.85.215.46 as permitted sender) Received: from [209.85.215.46] (HELO mail-la0-f46.google.com) (209.85.215.46) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2013 23:44:59 +0000 Received: by mail-la0-f46.google.com with SMTP id fq12so2835358lab.5 for ; Thu, 14 Feb 2013 15:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=uXqs+KqF+zuNjoyyU19+pHBFHS3+PeOIIBayhLjtFh4=; b=IwKvV//ClKN5zbyNR5AMQFpwB3uLCs/04l4IGZq/M4WL7jFjpx0hg4sIWw4bXDQLZB wP/aun61siQAPGWHER4Zuq4eNzOxSeLvt/g6MEg7hq9zhRQJP2buhsNftUmUcLpMAtSk z4VQi/sWRnkRkDI8zLZeikG5xeHbiLIqCIE3oXQo+DVC+YKvhfEij5mTWF7XJ9EfTYD6 Q0aPZJJGower2TUQwy/nF8YCCBWDBJ59uiJ7IvUIP0O9OwIXuD0gfs0GiEHLW7/u9j2K 6CiLqqJUG832Wry7654BR+ZbJEEBnS1t+/d30ldOpe4aItaXCgIg5hQ/ODVY2RIE+KJr PGPA== MIME-Version: 1.0 X-Received: by 10.112.30.104 with SMTP id r8mr1351648lbh.82.1360885478831; Thu, 14 Feb 2013 15:44:38 -0800 (PST) Received: by 10.112.6.2 with HTTP; Thu, 14 Feb 2013 15:44:38 -0800 (PST) In-Reply-To: <20130214224922.21380.66067@reviews.apache.org> References: <20130214214706.9635.24415@reviews.apache.org> <20130214224922.21380.66067@reviews.apache.org> Date: Thu, 14 Feb 2013 18:44:38 -0500 Message-ID: Subject: Re: Review Request: SHINDIG-1901 container.preloadCaches() should fire ON_PRELOAD lifecycle handlers From: Matt Franklin To: "dev@shindig.apache.org" , Ryan Baxter Content-Type: multipart/alternative; boundary=f46d04016b398bb87304d5b7d7c3 X-Virus-Checked: Checked by ClamAV on apache.org --f46d04016b398bb87304d5b7d7c3 Content-Type: text/plain; charset=ISO-8859-1 On Thursday, February 14, 2013, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9335/#review16615 > ----------------------------------------------------------- > > Ship it! > > > Committed revision 1446375. Please close the review. Reviewers should now be able to close reviews in reviewboard. Do we want to change the process so that the committer just closes the review? > > - Ryan Baxter > > > On Feb. 14, 2013, 9:47 p.m., Erin Noe-Payne wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/9335/ > > ----------------------------------------------------------- > > > > (Updated Feb. 14, 2013, 9:47 p.m.) > > > > > > Review request for shindig. > > > > > > Description > > ------- > > > > update preloadCaches() to fire ON_BEFORE_PRELOAD and ON_PRELOADED events. > > > > update opensearch feature to check for modulePrefs to prevent errors > during testing > > > > > > This addresses bug SHINDIG-1901. > > https://issues.apache.org/jira/browse/SHINDIG-1901 > > > > > > Diffs > > ----- > > > > trunk/features/src/main/javascript/features/container/container.js > 1446343 > > trunk/features/src/main/javascript/features/opensearch/opensearch.js > 1446343 > > > trunk/features/src/test/javascript/features/container/container_test.js > 1446343 > > > > Diff: https://reviews.apache.org/r/9335/diff/ > > > > > > Testing > > ------- > > > > Built and run with apache rave, tested with actions feature > > > > > > Thanks, > > > > Erin Noe-Payne > > > > > > --f46d04016b398bb87304d5b7d7c3--