Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DE1AEBB2 for ; Wed, 13 Feb 2013 00:04:13 +0000 (UTC) Received: (qmail 54412 invoked by uid 500); 13 Feb 2013 00:04:13 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 54386 invoked by uid 500); 13 Feb 2013 00:04:13 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 54369 invoked by uid 99); 13 Feb 2013 00:04:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Feb 2013 00:04:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 850401C74A6; Wed, 13 Feb 2013 00:04:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3770994950478495424==" MIME-Version: 1.0 Subject: Re: Review Request: gadget iframe accessibility fixes From: "Ryan Baxter" To: "Rich Thompson" , "Dan Dumont" , "Stanton Sievers" , "Ryan Baxter" Cc: "shindig" , "Marshall Shi" Date: Wed, 13 Feb 2013 00:04:05 -0000 Message-ID: <20130213000405.9635.381@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ryan Baxter" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/9308/ X-Sender: "Ryan Baxter" References: <20130205075705.13217.52722@reviews.apache.org> In-Reply-To: <20130205075705.13217.52722@reviews.apache.org> Reply-To: "Ryan Baxter" --===============3770994950478495424== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9308/#review16493 ----------------------------------------------------------- Marshal I am seeing feature javascript test failures when I apply this patc= h and do a build, can you please take a look? - Ryan Baxter On Feb. 5, 2013, 7:57 a.m., Marshall Shi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9308/ > ----------------------------------------------------------- > = > (Updated Feb. 5, 2013, 7:57 a.m.) > = > = > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and= Rich Thompson. > = > = > Description > ------- > = > One more fix for my previous patch of gadget iframe accessibility fixes. > https://reviews.apache.org/r/6561/ > = > = > This addresses bug shindig-1835. > https://issues.apache.org/jira/browse/shindig-1835 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.site.gadget/gadget_holder.js 1431869 = > = > Diff: https://reviews.apache.org/r/9308/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Marshall Shi > = > --===============3770994950478495424==--