shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbaxte...@gmail.com
Subject Re: Review Request: SHINDIG-1901 container.preloadCaches() should fire ON_PRELOAD lifecycle handlers
Date Thu, 14 Feb 2013 23:50:20 GMT

On Feb 14, 2013, at 6:44 PM, Matt Franklin <m.ben.franklin@gmail.com> wrote:

> On Thursday, February 14, 2013, Ryan Baxter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9335/#review16615
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Committed revision 1446375.  Please close the review.
> 
> Reviewers should now be able to close reviews in reviewboard.  Do we want to change the
process so that the committer just closes the review?
>  
I don't see an option to close the review when I look at other peoples reviews.

> 
> - Ryan Baxter
> 
> 
> On Feb. 14, 2013, 9:47 p.m., Erin Noe-Payne wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9335/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 14, 2013, 9:47 p.m.)
> >
> >
> > Review request for shindig.
> >
> >
> > Description
> > -------
> >
> > update preloadCaches() to fire ON_BEFORE_PRELOAD and ON_PRELOADED events.
> >
> > update opensearch feature to check for modulePrefs to prevent errors during testing
> >
> >
> > This addresses bug SHINDIG-1901.
> >     https://issues.apache.org/jira/browse/SHINDIG-1901
> >
> >
> > Diffs
> > -----
> >
> >   trunk/features/src/main/javascript/features/container/container.js 1446343
> >   trunk/features/src/main/javascript/features/opensearch/opensearch.js 1446343
> >   trunk/features/src/test/javascript/features/container/container_test.js 1446343
> >
> > Diff: https://reviews.apache.org/r/9335/diff/
> >
> >
> > Testing
> > -------
> >
> > Built and run with apache rave, tested with actions feature
> >
> >
> > Thanks,
> >
> > Erin Noe-Payne
> >
> >
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message