shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erin Noe-Payne" <eri...@mitre.org>
Subject Re: Review Request: SHINDIG-1901 container.preloadCaches() should fire ON_PRELOAD lifecycle handlers
Date Thu, 14 Feb 2013 21:27:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9335/
-----------------------------------------------------------

(Updated Feb. 14, 2013, 9:27 p.m.)


Review request for shindig.


Changes
-------

updated project and regenerated diff


Description
-------

update preloadCaches() to fire ON_BEFORE_PRELOAD and ON_PRELOADED events.

update opensearch feature to check for modulePrefs to prevent errors during testing


This addresses bug SHINDIG-1901.
    https://issues.apache.org/jira/browse/SHINDIG-1901


Diffs (updated)
-----

  tags/shindig-project-2.5.0-beta5/features/src/main/javascript/features/container/container.js
1446325 
  tags/shindig-project-2.5.0-beta5/features/src/main/javascript/features/opensearch/opensearch.js
1446325 
  tags/shindig-project-2.5.0-beta5/features/src/test/javascript/features/container/container_test.js
1446325 

Diff: https://reviews.apache.org/r/9335/diff/


Testing
-------

Built and run with apache rave, tested with actions feature


Thanks,

Erin Noe-Payne


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message