shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: SHINDIG-1901 container.preloadCaches() should fire ON_PRELOAD lifecycle handlers
Date Thu, 14 Feb 2013 21:01:54 GMT


> On Feb. 14, 2013, 3:25 p.m., Ryan Baxter wrote:
> > Erin I am getting errors in container.js trying to apply the patch to trunk, can
you take a look?
> 
> Erin Noe-Payne wrote:
>     Sure. What do I need to do to look / test?

Not sure I didn't look to deep into it.  It is probably that container.js has been updated
since you created the patch file, so you probably need to just update from trunk and recreate
the patch.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9335/#review16582
-----------------------------------------------------------


On Feb. 6, 2013, 8:34 p.m., Erin Noe-Payne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9335/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 8:34 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> update preloadCaches() to fire ON_BEFORE_PRELOAD and ON_PRELOADED events.
> 
> update opensearch feature to check for modulePrefs to prevent errors during testing
> 
> 
> This addresses bug SHINDIG-1901.
>     https://issues.apache.org/jira/browse/SHINDIG-1901
> 
> 
> Diffs
> -----
> 
>   tags/shindig-project-2.5.0-beta5/features/src/main/javascript/features/container/container.js
1443179 
>   tags/shindig-project-2.5.0-beta5/features/src/main/javascript/features/opensearch/opensearch.js
1443179 
>   tags/shindig-project-2.5.0-beta5/features/src/test/javascript/features/container/container_test.js
1443179 
> 
> Diff: https://reviews.apache.org/r/9335/diff/
> 
> 
> Testing
> -------
> 
> Built and run with apache rave, tested with actions feature
> 
> 
> Thanks,
> 
> Erin Noe-Payne
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message