shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: gadget iframe accessibility fixes
Date Wed, 13 Feb 2013 00:04:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9308/#review16493
-----------------------------------------------------------


Marshal I am seeing feature javascript test failures when I apply this patch and do a build,
can you please take a look?

- Ryan Baxter


On Feb. 5, 2013, 7:57 a.m., Marshall Shi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9308/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 7:57 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
> 
> 
> Description
> -------
> 
> One more fix for my previous patch of gadget iframe accessibility fixes.
> https://reviews.apache.org/r/6561/
> 
> 
> This addresses bug shindig-1835.
>     https://issues.apache.org/jira/browse/shindig-1835
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
1431869 
> 
> Diff: https://reviews.apache.org/r/9308/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marshall Shi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message