shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From René Peinl <rene.pe...@hof-university.de>
Subject Re: Review Request: partial solution for Shindig issue 1899 (create friend relations)
Date Tue, 12 Feb 2013 08:49:46 GMT


> On Feb. 12, 2013, 1:49 a.m., Ryan Baxter wrote:
> > Rene it looks like you close the issues Dan raised but it doesn't look they were
actually fixed in the code, do you plan on updating the patch?

I updated the patch in Jira, where I think it belongs. I forgot about the redundant data storing
here in reviews and didn't update here. 
My research topic is systems integration and it seems that the Apache foundation has not yet
heard about such a thing. Double logins, double patch submission. This really sucks.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9177/#review16455
-----------------------------------------------------------


On Feb. 12, 2013, 8:49 a.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9177/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 8:49 a.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> see https://issues.apache.org/jira/browse/SHINDIG-1899
> 
> 
> This addresses bug SHINDIG-1899.
>     https://issues.apache.org/jira/browse/SHINDIG-1899
> 
> 
> Diffs
> -----
> 
>   /trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/JPASocialModule.java
1437957 
>   /trunk/java/social-api/pom.xml 1437957 
>   /trunk/java/social-api/src/main/java/org/apache/shindig/social/core/spi/FriendServiceImpl.java
PRE-CREATION 
>   /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java
1437957 
>   /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/FriendService.java
PRE-CREATION 
>   /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/SampleModule.java
1437957 
>   /trunk/java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java
1437957 
>   /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java
1437957 
> 
> Diff: https://reviews.apache.org/r/9177/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message