shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: Do enhancement for FeatureRegistry to detect feature dependency loop problem
Date Tue, 12 Feb 2013 01:36:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7497/#review16454
-----------------------------------------------------------


Can you add a unit test which tests this case?

- Ryan Baxter


On Feb. 5, 2013, 3:18 a.m., Jiaqing Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7497/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 3:18 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> This patch is used to fix bug SHINDIG-1877.
> It will do a enhancement for FeatureRegistry to detect feature dependency loop problem
when it tries to complete dependency node graph for loaded feature node.
> 
> 
> This addresses bug SHINDIG-1877.
>     https://issues.apache.org/jira/browse/SHINDIG-1877
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java
1442011 
> 
> Diff: https://reviews.apache.org/r/7497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiaqing Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message