shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiaqing Guo" <guoj...@cn.ibm.com>
Subject Re: Review Request: Do enhancement for FeatureRegistry to detect feature dependency loop problem
Date Fri, 08 Feb 2013 01:04:15 GMT


> On Feb. 5, 2013, 6:17 a.m., Henry Saputra wrote:
> > I thought the code completeNodeGraph is used to check dependency loop and discard
A in case of A->B->C->A ?

Method "completeNodeGraph" is used to create dependency graph for each feature node.
It has a simple check mechanism for dependency loop problem but it is not valid in case of
A->B->C->A,
so, in this case, method "completeNodeGraph" will be in a dead loop.
This patch is used to fix this problem.


- Jiaqing


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7497/#review16083
-----------------------------------------------------------


On Feb. 5, 2013, 3:18 a.m., Jiaqing Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7497/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 3:18 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> This patch is used to fix bug SHINDIG-1877.
> It will do a enhancement for FeatureRegistry to detect feature dependency loop problem
when it tries to complete dependency node graph for loaded feature node.
> 
> 
> This addresses bug SHINDIG-1877.
>     https://issues.apache.org/jira/browse/SHINDIG-1877
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java
1442011 
> 
> Diff: https://reviews.apache.org/r/7497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiaqing Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message