shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Dumont" <ddum...@us.ibm.com>
Subject Re: Review Request: schema is hardcoded in shindig.properties
Date Wed, 06 Feb 2013 16:00:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9324/#review16184
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Dumont


On Feb. 6, 2013, 5:51 a.m., Zhi Hong Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9324/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 5:51 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
> 
> 
> Description
> -------
> 
> in shindig.properties, the scheme is hardcoded in following setting:
> shindig.signing.global-callback-url=http://%authority%%contextRoot%/gadgets/oauthcallback
> shindig.oauth2.global-redirect-uri=http://%authority%%contextRoot%/gadgets/oauth2callback
> should be fixed as :
> shindig.signing.global-callback-url=%scheme%://%authority%%contextRoot%/gadgets/oauthcallback
> shindig.oauth2.global-redirect-uri=%scheme%://%authority%%contextRoot%/gadgets/oauth2callback
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1442845

> 
> Diff: https://reviews.apache.org/r/9324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhi Hong Yang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message