shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhi Hong Yang" <zhiho...@cn.ibm.com>
Subject Review Request: schema is hardcoded in shindig.properties
Date Wed, 06 Feb 2013 05:51:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9324/
-----------------------------------------------------------

Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.


Description
-------

in shindig.properties, the scheme is hardcoded in following setting:
shindig.signing.global-callback-url=http://%authority%%contextRoot%/gadgets/oauthcallback
shindig.oauth2.global-redirect-uri=http://%authority%%contextRoot%/gadgets/oauth2callback
should be fixed as :
shindig.signing.global-callback-url=%scheme%://%authority%%contextRoot%/gadgets/oauthcallback
shindig.oauth2.global-redirect-uri=%scheme%://%authority%%contextRoot%/gadgets/oauth2callback


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1442845


Diff: https://reviews.apache.org/r/9324/diff/


Testing
-------


Thanks,

Zhi Hong Yang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message