shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Clarke" <cla...@gmail.com>
Subject Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.
Date Fri, 24 Aug 2012 13:04:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436/
-----------------------------------------------------------

(Updated Aug. 24, 2012, 1:04 p.m.)


Review request for shindig, Stanton Sievers, Brian Lillie, and Marshall Shi.


Changes
-------

Addresses comments.  Still an open issue on the synchronized block in BasicOAuth2Request.


Description
-------

Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

Applied formatting and Checkstyle fixes to all changed files.
MapCache inconsistent null checks for storing Collections.
update OAuth2Persister javadoc to clarify what findClient() should return.
BasicOAuth2Store improve removeToken() logic, from Brian Lillie.
Refreshing Token does not include originator info.
Improve information propagated through OAuth2RequestException.
More complete filtering of server information when sendTraceToClient is disabled.
Log when an invalid or error OAuth2Accessor is used for redirect.
Limit concurrent refreshes to 1, syncrhonizing on interned accessor string.
Refresh token is not properly removed on provider error.
Allow clearing of accessor cache on OAuth2Store.


This addresses bug SHINDIG-1839.
    https://issues.apache.org/jira/browse/SHINDIG-1839


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BearerTokenHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/MacTokenHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandler.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/MapCache.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandlerTest.java
1376889 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java
1376889 

Diff: https://reviews.apache.org/r/6436/diff/


Testing
-------

All existing JUnits pass


Thanks,

Adam Clarke


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message