Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A415BDC55 for ; Tue, 31 Jul 2012 09:26:59 +0000 (UTC) Received: (qmail 13107 invoked by uid 500); 31 Jul 2012 09:26:59 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 12976 invoked by uid 500); 31 Jul 2012 09:26:58 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 12932 invoked by uid 99); 31 Jul 2012 09:26:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2012 09:26:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3E4701C0378; Tue, 31 Jul 2012 09:26:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7559276436353268971==" MIME-Version: 1.0 Subject: Re: Review Request: Absence of an error code in case of wrong gadget URL From: "Marshall Shi" To: "Dan Dumont" , "Stanton Sievers" , "Ryan Baxter" Cc: "shindig" , "Marshall Shi" Date: Tue, 31 Jul 2012 09:26:56 -0000 Message-ID: <20120731092656.22301.69089@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Marshall Shi" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6202/ X-Sender: "Marshall Shi" References: <20120731092551.22301.65251@reviews.apache.org> In-Reply-To: <20120731092551.22301.65251@reviews.apache.org> Reply-To: "Marshall Shi" --===============7559276436353268971== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6202/ ----------------------------------------------------------- (Updated July 31, 2012, 9:26 a.m.) Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. Description ------- Currently, when you specify wrong gadget URL - in SystemOut.log you would g= et: [5/1/12 16:53:33:409 IST] 0000005e AbstractSpecF I org.apache.shindig.gadge= ts.AbstractSpecFactory SpecUpdater An error occurred when updating XXXXX. A= cached version is being used instead. It should report 404 code in that error message, with the exception message= , and also the message is warning level not info level. = This addresses bug shindig-1832. https://issues.apache.org/jira/browse/shindig-1832 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resour= ces/org/apache/shindig/common/logging/i18n/resource.properties 1351249 = http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resour= ces/org/apache/shindig/common/logging/i18n/resource_en_US.properties 135124= 9 = http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/= org/apache/shindig/gadgets/AbstractSpecFactory.java 1362303 = Diff: https://reviews.apache.org/r/6202/diff/ Testing (updated) ------- Fixed a compile error of Anonymous security token as well. Thanks, Marshall Shi --===============7559276436353268971==--