Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 595BBD1A1 for ; Fri, 27 Jul 2012 16:03:29 +0000 (UTC) Received: (qmail 12784 invoked by uid 500); 27 Jul 2012 16:03:29 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 12758 invoked by uid 500); 27 Jul 2012 16:03:29 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 12748 invoked by uid 99); 27 Jul 2012 16:03:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2012 16:03:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 267121C188E; Fri, 27 Jul 2012 16:03:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6362720342178413649==" MIME-Version: 1.0 Subject: Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp From: "Mike May" To: "Ryan Baxter" Cc: "shindig" , "Mike May" Date: Fri, 27 Jul 2012 16:03:28 -0000 Message-ID: <20120727160328.4031.11288@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mike May" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6155/ X-Sender: "Mike May" References: <20120726231513.4031.589@reviews.apache.org> In-Reply-To: <20120726231513.4031.589@reviews.apache.org> Reply-To: "Mike May" --===============6362720342178413649== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On July 26, 2012, 11:15 p.m., Ryan Baxter wrote: > > Ship It! > = > Ryan Baxter wrote: > Committed revision 1366425 > = > Ryan Baxter wrote: > Mike can you attach the patch to the JIRA? I should have checked thi= s first before checking it in. Attached! My bad, thought I had already attached it. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6155/#review9522 ----------------------------------------------------------- On July 26, 2012, 5:26 p.m., Mike May wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6155/ > ----------------------------------------------------------- > = > (Updated July 26, 2012, 5:26 p.m.) > = > = > Review request for shindig and Ryan Baxter. > = > = > Description > ------- > = > The forms and the form elements in login.jsp and authorize.jsp do not hav= e IDs. > = > = > This addresses bug SHINDIG-1828. > https://issues.apache.org/jira/browse/SHINDIG-1828 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src= /main/webapp/WEB-INF/authorize.jsp 1366029 = > http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src= /main/webapp/login.jsp 1366029 = > = > Diff: https://reviews.apache.org/r/6155/diff/ > = > = > Testing > ------- > = > All tests pass. > = > = > Thanks, > = > Mike May > = > --===============6362720342178413649==--