Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB750DED6 for ; Thu, 26 Jul 2012 17:24:09 +0000 (UTC) Received: (qmail 40523 invoked by uid 500); 26 Jul 2012 17:24:09 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 40502 invoked by uid 500); 26 Jul 2012 17:24:09 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 40485 invoked by uid 99); 26 Jul 2012 17:24:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jul 2012 17:24:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DDBC11C0687; Thu, 26 Jul 2012 17:24:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2719998042290010512==" MIME-Version: 1.0 Subject: Re: Review Request: Data pipelining request not working when container in SSL mode From: "Henry Saputra" To: "Dan Dumont" , "Stanton Sievers" , "Ryan Baxter" Cc: "Henry Saputra" , "shindig" , "Erik Bi" Date: Thu, 26 Jul 2012 17:24:08 -0000 Message-ID: <20120726172408.4030.26075@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Henry Saputra" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6084/ X-Sender: "Henry Saputra" References: <20120726015847.4030.6293@reviews.apache.org> In-Reply-To: <20120726015847.4030.6293@reviews.apache.org> Reply-To: "Henry Saputra" --===============2719998042290010512== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6084/#review9504 ----------------------------------------------------------- Ship it! +1 LGTM - Henry Saputra On July 26, 2012, 1:58 a.m., Erik Bi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6084/ > ----------------------------------------------------------- > = > (Updated July 26, 2012, 1:58 a.m.) > = > = > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > = > = > Description > ------- > = > load a gadget that uses data pipeline tag like t= o request the current viewer fails if the container is under SSL mode. = > = > If the gadget test page is loaded in non-SSL mode, the gadget can retriev= e the viewer with no problem. = > = > If the gadget test page is loaded in SSL mode, the gadget can't retrieve = the viewer = > = > It's only the mode of the container that seems relevant. In container non= -ssl mode, the gadget itself can be retrieved with a SSL or non-SSL url and= it works ok. > = > = > This addresses bug shindig-1797. > https://issues.apache.org/jira/browse/shindig-1797 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 13649= 57 = > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/e= xamples/datapipeline/ViewerRequestTest.xml PRE-CREATION = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/GadgetContext.java 1364957 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java 1364957 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/HttpGadgetContext.java 1364957 = > = > Diff: https://reviews.apache.org/r/6084/diff/ > = > = > Testing > ------- > = > Tested in local SSL environment with test gadget. Attached the test gadge= t here as well. > = > = > Thanks, > = > Erik Bi > = > --===============2719998042290010512==--