Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59C1ADD58 for ; Thu, 26 Jul 2012 01:58:48 +0000 (UTC) Received: (qmail 97801 invoked by uid 500); 26 Jul 2012 01:58:48 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 97717 invoked by uid 500); 26 Jul 2012 01:58:48 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 97705 invoked by uid 99); 26 Jul 2012 01:58:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jul 2012 01:58:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 58CB51C0502; Thu, 26 Jul 2012 01:58:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8584995646538897286==" MIME-Version: 1.0 Subject: Re: Review Request: Data pipelining request not working when container in SSL mode From: "Erik Bi" To: "Dan Dumont" , "Stanton Sievers" , "Ryan Baxter" Cc: "Erik Bi" , "shindig" Date: Thu, 26 Jul 2012 01:58:47 -0000 Message-ID: <20120726015847.4030.6293@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Erik Bi" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6084/ X-Sender: "Erik Bi" References: <20120724100258.4030.24061@reviews.apache.org> In-Reply-To: <20120724100258.4030.24061@reviews.apache.org> Reply-To: "Erik Bi" --===============8584995646538897286== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6084/ ----------------------------------------------------------- (Updated July 26, 2012, 1:58 a.m.) Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. Description ------- load a gadget that uses data pipeline tag like to = request the current viewer fails if the container is under SSL mode. = If the gadget test page is loaded in non-SSL mode, the gadget can retrieve = the viewer with no problem. = If the gadget test page is loaded in SSL mode, the gadget can't retrieve th= e viewer = It's only the mode of the container that seems relevant. In container non-s= sl mode, the gadget itself can be retrieved with a SSL or non-SSL url and i= t works ok. This addresses bug shindig-1797. https://issues.apache.org/jira/browse/shindig-1797 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1364957 = http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/exa= mples/datapipeline/ViewerRequestTest.xml PRE-CREATION = http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/= org/apache/shindig/gadgets/GadgetContext.java 1364957 = http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/= org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java 1364957 = http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/= org/apache/shindig/gadgets/servlet/HttpGadgetContext.java 1364957 = Diff: https://reviews.apache.org/r/6084/diff/ Testing ------- Tested in local SSL environment with test gadget. Attached the test gadget = here as well. Thanks, Erik Bi --===============8584995646538897286==--