Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2A6A6DD03 for ; Wed, 25 Jul 2012 00:09:11 +0000 (UTC) Received: (qmail 71285 invoked by uid 500); 25 Jul 2012 00:09:10 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 71230 invoked by uid 500); 25 Jul 2012 00:09:10 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 71214 invoked by uid 99); 25 Jul 2012 00:09:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jul 2012 00:09:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C79B61C17CC; Wed, 25 Jul 2012 00:09:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1489651044989681233==" MIME-Version: 1.0 Subject: Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT From: "Ryan Baxter" To: "Stanton Sievers" , "Ryan Baxter" Cc: "shindig" , "Adam Clarke" , "Matt Franklin" Date: Wed, 25 Jul 2012 00:09:09 -0000 Message-ID: <20120725000909.4031.43555@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ryan Baxter" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6035/ X-Sender: "Ryan Baxter" References: <20120724192432.4030.87177@reviews.apache.org> In-Reply-To: <20120724192432.4030.87177@reviews.apache.org> Reply-To: "Ryan Baxter" --===============1489651044989681233== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On July 24, 2012, 7:24 p.m., Matt Franklin wrote: > > Was this applied yet? > = > Stanton Sievers wrote: > No, not yet. Consider this last call. If there are no other comment= s I'll commit the patch in the next day. I committed this so we can get it in beta3 which I want to work on tonight. Committed revision 1365361 - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/#review9405 ----------------------------------------------------------- On July 18, 2012, 7:45 p.m., Adam Clarke wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6035/ > ----------------------------------------------------------- > = > (Updated July 18, 2012, 7:45 p.m.) > = > = > Review request for shindig, Ryan Baxter and Stanton Sievers. > = > = > Description > ------- > = > Adds two new settings to oauth.json (or other persistence plugins) to han= dle picky OAuth1.0a providers. > = > 1) New key_type "PLAINTEXT" > "key_type" : "PLAINTEXT" > Default remains "key_type" : "HMAC_SYMMETRIC" > = > 2) New field "bodyHash" that won't put extra params like "oauth_body_hash= " on requests > "bodyHash" : "false" > Default is "true" to keep compatibility with existing configurations > = > = > This addresses bug SHINDIG-1775. > https://issues.apache.org/jira/browse/SHINDIG-1775 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java 1363028 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java= 1363028 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1363028 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/OAuthStore.java 1363028 = > = > Diff: https://reviews.apache.org/r/6035/diff/ > = > = > Testing > ------- > = > All JUnits pass. > = > = > Thanks, > = > Adam Clarke > = > --===============1489651044989681233==--