Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D36EED8A9 for ; Tue, 24 Jul 2012 19:24:33 +0000 (UTC) Received: (qmail 56544 invoked by uid 500); 24 Jul 2012 19:24:33 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 56509 invoked by uid 500); 24 Jul 2012 19:24:33 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 56491 invoked by uid 99); 24 Jul 2012 19:24:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2012 19:24:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8FD0F1C17CC; Tue, 24 Jul 2012 19:24:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5252783531823418276==" MIME-Version: 1.0 Subject: Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT From: "Matt Franklin" To: "Stanton Sievers" , "Ryan Baxter" Cc: "Matt Franklin" , "Adam Clarke" , "shindig" Date: Tue, 24 Jul 2012 19:24:32 -0000 Message-ID: <20120724192432.4030.87177@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Matt Franklin" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6035/ X-Sender: "Matt Franklin" References: <20120718194529.14854.92483@reviews.apache.org> In-Reply-To: <20120718194529.14854.92483@reviews.apache.org> Reply-To: "Matt Franklin" --===============5252783531823418276== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/#review9405 ----------------------------------------------------------- Ship it! Was this applied yet? - Matt Franklin On July 18, 2012, 7:45 p.m., Adam Clarke wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6035/ > ----------------------------------------------------------- > = > (Updated July 18, 2012, 7:45 p.m.) > = > = > Review request for shindig, Ryan Baxter and Stanton Sievers. > = > = > Description > ------- > = > Adds two new settings to oauth.json (or other persistence plugins) to han= dle picky OAuth1.0a providers. > = > 1) New key_type "PLAINTEXT" > "key_type" : "PLAINTEXT" > Default remains "key_type" : "HMAC_SYMMETRIC" > = > 2) New field "bodyHash" that won't put extra params like "oauth_body_hash= " on requests > "bodyHash" : "false" > Default is "true" to keep compatibility with existing configurations > = > = > This addresses bug SHINDIG-1775. > https://issues.apache.org/jira/browse/SHINDIG-1775 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java 1363028 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java= 1363028 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1363028 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/oauth/OAuthStore.java 1363028 = > = > Diff: https://reviews.apache.org/r/6035/diff/ > = > = > Testing > ------- > = > All JUnits pass. > = > = > Thanks, > = > Adam Clarke > = > --===============5252783531823418276==--