Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AFDE6DFA1 for ; Tue, 24 Jul 2012 12:13:43 +0000 (UTC) Received: (qmail 69657 invoked by uid 500); 24 Jul 2012 12:13:43 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 69574 invoked by uid 500); 24 Jul 2012 12:13:42 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 69322 invoked by uid 99); 24 Jul 2012 12:13:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2012 12:13:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 236EE1C0238; Tue, 24 Jul 2012 12:13:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2287821876006055475==" MIME-Version: 1.0 Subject: Re: Review Request: content-type for "multipart/form-data" is incorrect From: "Ryan Baxter" To: "Dan Dumont" , "Stanton Sievers" , "Ryan Baxter" Cc: "shindig" , "Erik Bi" , "Henry Saputra" Date: Tue, 24 Jul 2012 12:13:40 -0000 Message-ID: <20120724121340.4031.90079@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ryan Baxter" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6087/ X-Sender: "Ryan Baxter" References: <20120724051919.4031.53403@reviews.apache.org> In-Reply-To: <20120724051919.4031.53403@reviews.apache.org> Reply-To: "Ryan Baxter" --===============2287821876006055475== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On July 24, 2012, 5:19 a.m., Henry Saputra wrote: > > +1 > > = > > @ryan I knew there was issue with file upload =3DP I knew we had a fix for it but I thought we already checked it in :) - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6087/#review9390 ----------------------------------------------------------- On July 24, 2012, 2:06 a.m., Erik Bi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6087/ > ----------------------------------------------------------- > = > (Updated July 24, 2012, 2:06 a.m.) > = > = > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > = > = > Description > ------- > = > When submitting a multipart/form-data form, the "content-type" head prope= rty is set to "multipart/form-data,multipart/form-data; boundary=3D----XXXX= X". = > This caused the failure of uploading files > = > The reason for this is: the Class MakeRequestHandler should use "setHeade= r" instead of "addHeader" when it copy the header from response. = > = > = > This addresses bug shindig-1823. > https://issues.apache.org/jira/browse/shindig-1823 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1327432 = > = > Diff: https://reviews.apache.org/r/6087/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Erik Bi > = > --===============2287821876006055475==--