Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57ACFDBE9 for ; Mon, 23 Jul 2012 17:35:16 +0000 (UTC) Received: (qmail 25741 invoked by uid 500); 23 Jul 2012 17:35:16 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 25716 invoked by uid 500); 23 Jul 2012 17:35:15 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 25690 invoked by uid 99); 23 Jul 2012 17:35:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2012 17:35:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 817E11C02E2; Mon, 23 Jul 2012 17:35:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5597404036876093834==" MIME-Version: 1.0 Subject: Re: Review Request: Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used in YUI2 connection manager From: "Henry Saputra" To: "shindig" , "Ryan Baxter" , "Stanton Sievers" , "Henry Saputra" Date: Mon, 23 Jul 2012 17:35:14 -0000 Message-ID: <20120723173514.4030.49772@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Henry Saputra" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/6070/ X-Sender: "Henry Saputra" References: <20120721001617.14836.13103@reviews.apache.org> In-Reply-To: <20120721001617.14836.13103@reviews.apache.org> Reply-To: "Henry Saputra" --===============5597404036876093834== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6070/ ----------------------------------------------------------- (Updated July 23, 2012, 5:35 p.m.) Review request for shindig. Changes ------- Update based on review: * Update patch to only detect for IE7 in the util function. * This will avoid check availability of activex object in user setting whic= h can be turned off Description ------- Fix memory leak in IE7 for Ajax call in core.io feature using polling techn= ique used in YUI2 connection manager. The leak happen due to circular link that ajax onreadystatechange handler t= hat has link to the main xhr object. IE garbage collector hates that. Diffs (updated) ----- trunk/config/container.js 1363863 = trunk/features/src/main/javascript/features/core.io/io.js 1363863 = trunk/features/src/main/javascript/features/core.util.base/base.js 136386= 3 = Diff: https://reviews.apache.org/r/6070/diff/ Testing ------- Pass unit tests and in common container. Thanks, Henry Saputra --===============5597404036876093834==--