Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 022FDD93C for ; Sun, 8 Jul 2012 19:30:38 +0000 (UTC) Received: (qmail 16755 invoked by uid 500); 8 Jul 2012 19:30:37 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 16716 invoked by uid 500); 8 Jul 2012 19:30:37 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 16700 invoked by uid 99); 8 Jul 2012 19:30:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Jul 2012 19:30:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 38AA51C00A2; Sun, 8 Jul 2012 19:30:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2958828084507701236==" MIME-Version: 1.0 Subject: Re: Review Request: Change the check for child RPC to also verify if parent url parameter exists From: "Ryan Baxter" To: "shindig" , "Henry Saputra" , "Ryan Baxter" Date: Sun, 08 Jul 2012 19:30:37 -0000 Message-ID: <20120708193037.766.61358@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ryan Baxter" X-ReviewGroup: shindig X-ReviewRequest-URL: https://reviews.apache.org/r/5810/ X-Sender: "Ryan Baxter" References: <20120706181140.1165.42476@reviews.apache.org> In-Reply-To: <20120706181140.1165.42476@reviews.apache.org> Reply-To: "Ryan Baxter" --===============2958828084507701236== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5810/#review8952 ----------------------------------------------------------- Is there a JIRA? trunk/features/src/main/javascript/features/rpc/rpc.js Do we need the if else here? - Ryan Baxter On July 6, 2012, 6:11 p.m., Henry Saputra wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5810/ > ----------------------------------------------------------- > = > (Updated July 6, 2012, 6:11 p.m.) > = > = > Review request for shindig. > = > = > Description > ------- > = > The Shindig container could be rendered inside parent iframe and in this = scenario, the rpc check for isChild (almost the same as check fro isGadget)= does not work well because its actually act as the real container even tho= ugh its put inside another iframe. > = > The proposed fix to add check for url param "parent" as well as the check= for window instance. > = > = > Diffs > ----- > = > trunk/features/src/main/javascript/features/rpc/rpc.js 1356941 = > = > Diff: https://reviews.apache.org/r/5810/diff/ > = > = > Testing > ------- > = > Unit tests still pass. Common container renders gadgets and rpc works as = expected. > = > = > Thanks, > = > Henry Saputra > = > --===============2958828084507701236==--