shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanton Sievers" <siever...@gmail.com>
Subject Re: Review Request: Absence of an error code in case of wrong gadget URL
Date Mon, 30 Jul 2012 10:42:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6202/#review9587
-----------------------------------------------------------


Why not go one step further and log the entire exception (or maybe just the message from the
exception) if you have it?  In the event of something other than a 404, the message will most
likely be useful.

- Stanton Sievers


On July 30, 2012, 8:24 a.m., Marshall Shi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6202/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 8:24 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> Currently, when you specify wrong gadget URL - in SystemOut.log you would get:
> 
> [5/1/12 16:53:33:409 IST] 0000005e AbstractSpecF I org.apache.shindig.gadgets.AbstractSpecFactory
SpecUpdater An error occurred when updating XXXXX. A cached version is being used instead.
> 
> It should report 404 code in that error message, and also the message is warning level
not info level. 
> 
> 
> This addresses bug shindig-1832.
>     https://issues.apache.org/jira/browse/shindig-1832
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties
1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties
1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java
1362303 
> 
> Diff: https://reviews.apache.org/r/6202/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marshall Shi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message