shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marshall Shi" <shiwc...@cn.ibm.com>
Subject Review Request: gadget_holder.js file format cause the apply patch process broken
Date Mon, 30 Jul 2012 08:51:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6205/
-----------------------------------------------------------

Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.


Description
-------

In our Shindig extensions, we applied a few patches to gadget_holder.js, however, we found
the file format will break the patch process. We fixed this problem by updating the gadget_holder.js,
using a dos to unix file convert tool. 

Note: the file content is not changed.


This addresses bug shindig-1833.
    https://issues.apache.org/jira/browse/shindig-1833


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
1351249 

Diff: https://reviews.apache.org/r/6205/diff/


Testing
-------


Thanks,

Marshall Shi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message