shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp
Date Thu, 26 Jul 2012 23:15:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9522
-----------------------------------------------------------

Ship it!


Ship It!

- Ryan Baxter


On July 26, 2012, 5:26 p.m., Mike May wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 5:26 p.m.)
> 
> 
> Review request for shindig and Ryan Baxter.
> 
> 
> Description
> -------
> 
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
> 
> 
> This addresses bug SHINDIG-1828.
>     https://issues.apache.org/jira/browse/SHINDIG-1828
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp
1366029 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp
1366029 
> 
> Diff: https://reviews.apache.org/r/6155/diff/
> 
> 
> Testing
> -------
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Mike May
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message