shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra" <hsapu...@apache.org>
Subject Re: Review Request: Data pipelining request not working when container in SSL mode
Date Thu, 26 Jul 2012 17:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6084/#review9504
-----------------------------------------------------------

Ship it!


+1 LGTM

- Henry Saputra


On July 26, 2012, 1:58 a.m., Erik Bi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6084/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 1:58 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> load a gadget that uses data pipeline tag like <os: viewerRequest ... > to request
the current viewer fails if the container is under SSL mode. 
> 
> If the gadget test page is loaded in non-SSL mode, the gadget can retrieve the viewer
with no problem. 
> 
> If the gadget test page is loaded in SSL mode, the gadget can't retrieve the viewer 
> 
> It's only the mode of the container that seems relevant. In container non-ssl mode, the
gadget itself can be retrieved with a SSL or non-SSL url and it works ok.
> 
> 
> This addresses bug shindig-1797.
>     https://issues.apache.org/jira/browse/shindig-1797
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1364957 
>   http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/datapipeline/ViewerRequestTest.xml
PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetContext.java
1364957 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java
1364957 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpGadgetContext.java
1364957 
> 
> Diff: https://reviews.apache.org/r/6084/diff/
> 
> 
> Testing
> -------
> 
> Tested in local SSL environment with test gadget. Attached the test gadget here as well.
> 
> 
> Thanks,
> 
> Erik Bi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message