shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanton Sievers" <siever...@gmail.com>
Subject Re: Review Request: Allow container implementations to more easily override and extend rpc registered service handlers.
Date Wed, 25 Jul 2012 18:29:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6141/#review9464
-----------------------------------------------------------

Ship it!


Ship It!

- Stanton Sievers


On July 25, 2012, 6:27 p.m., Dan Dumont wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6141/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 6:27 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Change rpc registration to return the old handler if there were any so that container
implementations may call into the previously registered handler if they wish to extend the
existing behavior.
> 
> 
> This addresses bug SHINDIG-1827.
>     https://issues.apache.org/jira/browse/SHINDIG-1827
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1365569 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1365569 
> 
> Diff: https://reviews.apache.org/r/6141/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> Dan Dumont
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message