shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Bi" <bizh...@cn.ibm.com>
Subject Re: Review Request: content-type for "multipart/form-data" is incorrect
Date Tue, 24 Jul 2012 02:06:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6087/
-----------------------------------------------------------

(Updated July 24, 2012, 2:06 a.m.)


Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.


Description
-------

When submitting a multipart/form-data form, the "content-type" head property is set to "multipart/form-data,multipart/form-data;
boundary=----XXXXX". 
This caused the failure of uploading files

The reason for this is: the Class MakeRequestHandler should use "setHeader" instead of "addHeader"
when it copy the header from response. 


This addresses bug shindig-1823.
    https://issues.apache.org/jira/browse/shindig-1823


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1327432 

Diff: https://reviews.apache.org/r/6087/diff/


Testing
-------


Thanks,

Erik Bi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message