shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra" <hsapu...@apache.org>
Subject Re: Review Request: Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used in YUI2 connection manager
Date Mon, 23 Jul 2012 21:19:40 GMT


> On July 23, 2012, 9:15 p.m., Stanton Sievers wrote:
> > trunk/features/src/main/javascript/features/core.util.base/base.js, line 85
> > <https://reviews.apache.org/r/6070/diff/1-2/?file=125824#file125824line85>
> >
> >     I guess this is OK.  IE version checks like this make me sad inside... but I
don't have a better recommendation.

I almost cried when I need to add this check =P
Another way to do is to use poll for all browsers but then we "punishing" users for using
sensible browsers too.


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6070/#review9370
-----------------------------------------------------------


On July 23, 2012, 5:35 p.m., Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6070/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 5:35 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used
in YUI2 connection manager.
> 
> The leak happen due to circular link that ajax onreadystatechange handler that has link
to the main xhr object. IE garbage collector hates that.
> 
> 
> Diffs
> -----
> 
>   trunk/config/container.js 1363863 
>   trunk/features/src/main/javascript/features/core.io/io.js 1363863 
>   trunk/features/src/main/javascript/features/core.util.base/base.js 1363863 
> 
> Diff: https://reviews.apache.org/r/6070/diff/
> 
> 
> Testing
> -------
> 
> Pass unit tests and in common container.
> 
> 
> Thanks,
> 
> Henry Saputra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message