shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra" <hsapu...@apache.org>
Subject Re: Review Request: Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used in YUI2 connection manager
Date Mon, 23 Jul 2012 17:35:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6070/
-----------------------------------------------------------

(Updated July 23, 2012, 5:35 p.m.)


Review request for shindig.


Changes
-------

Update based on review:
* Update patch to only detect for IE7 in the util function.
* This will avoid check availability of activex object in user setting which can be turned
off


Description
-------

Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used in YUI2
connection manager.

The leak happen due to circular link that ajax onreadystatechange handler that has link to
the main xhr object. IE garbage collector hates that.


Diffs (updated)
-----

  trunk/config/container.js 1363863 
  trunk/features/src/main/javascript/features/core.io/io.js 1363863 
  trunk/features/src/main/javascript/features/core.util.base/base.js 1363863 

Diff: https://reviews.apache.org/r/6070/diff/


Testing
-------

Pass unit tests and in common container.


Thanks,

Henry Saputra


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message